chore: Fix publish in FlexCluster #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lantoli
force-pushed
the
CLOUDP-342254_publish_flex_cluster
branch
from
18ed769 to
0057334
Compare
lantoli
force-pushed
the
CLOUDP-342254_publish_flex_cluster
branch
from
bcb06f6 to
08f83f4
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the FlexCluster publish scripts by correcting the parameter passed to the test input generation script. The publish scripts expect the project name rather than the project ID as the first parameter.
- Fixed parameter type passed from project ID to project name in test script
- Updated test input generation script to handle project name and resolve project ID internally
- Added missing delete inputs script for publish workflow compliance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cfn-resources/flex-cluster/test/contract-testing/cfn-test-create.sh | Changed parameter from projectId to projectName when calling input generation script |
| cfn-resources/flex-cluster/test/cfn-test-delete-inputs.sh | Added empty cleanup script required by publish workflow |
| cfn-resources/flex-cluster/test/cfn-test-create-inputs.sh | Updated to accept project name instead of ID and handle project lookup/creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marcosuma
approved these changes
Sep 8, 2025
Collaborator
marcosuma
left a comment
marcosuma
left a comment
There was a problem hiding this comment.
I am guessing we've manually tested it now? Just making sure it is now confirmed it works.
Member
Author
|
@marcosuma correct, it failed the first time that flex-cluster publish was tried, I fixed it in this PR and confirmed it works now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix publish in FlexCluster. Publish scripts expect the project name not the project id as the first parameter.
Jira ticket: CLOUDP-342254
Please include a summary of the fix/feature/change, including any relevant motivation and context.
Link to any related issue(s):
Type of change:
expected)
Manual QA performed:
Required Checklist:
make fmtand formatted my codeworks in Atlas
Further comments